Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing update to state->back #207

Open
folkertdev opened this issue Sep 28, 2024 · 1 comment
Open

missing update to state->back #207

folkertdev opened this issue Sep 28, 2024 · 1 comment

Comments

@folkertdev
Copy link
Collaborator

we miss the state->back = -1 in our code. no idea when that is useful, but probably a bug.

            /* use inflate_fast() if we have enough input and output */
            if (have >= INFLATE_FAST_MIN_HAVE && left >= INFLATE_FAST_MIN_LEFT) {
                RESTORE();
                functable.inflate_fast(strm, out);
                LOAD();
                if (state->mode == TYPE)
                    state->back = -1;
                break;
            }
            state->back = 0;
@bjorn3
Copy link
Collaborator

bjorn3 commented Oct 1, 2024

This way added way back in zlib 1.2.3.4 in 2009: zlib-ng/zlib-ng@f6194ef#diff-a4d1ad62d5ea3dd46bc58016d6a642b364511e75ac9647c4dd33ff9a906777c7R1010 I couldn't find any commits for individual changes from the previous release though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants