Finishing reading when read canceled #156
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #154 , but the resulting code is so complex that I am not sure it's wort this. (Since it will probably have bugs because of the complexity.) Tested on UDP and Trezor T2. (Note that UDP emulator will hang, but that's not the issue of this fix. If we want to fix the hang/the black screen, we would also need to send empty Initialize after the read here.)
Besiktas19033
approved these changes
May 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #154 , but the resulting code is so complex that I am not sure it's worth this.
(Since it will probably have bugs because of the complexity.)
Tested on UDP and Trezor T2.
Depends on #153 (so see just the last commit for actual changes)
(Note that UDP emulator will hang, but that's not the issue of this fix. If we want to fix the hang/the black screen, we would also need to send empty Initialize after the read here, and then read the result.)