Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show nicer error when GPS not present for image input #13

Open
himynamesdave opened this issue Nov 16, 2022 · 0 comments
Open

Show nicer error when GPS not present for image input #13

himynamesdave opened this issue Nov 16, 2022 · 0 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@himynamesdave
Copy link
Member

Currently when an image (or images) entered as input have no GPS, the script has a hard failure:

Traceback (most recent call last):
  File "/Users/dgreenwood/Documents/repos/trek-view/telemetry-injector/telemetry-injector.py", line 96, in <module>
    main()
  File "/Users/dgreenwood/Documents/repos/trek-view/telemetry-injector/telemetry-injector.py", line 66, in main
    create_video_from_images(images_directory, output_dir, output_vid, o_vid, framerate, metadata)
  File "/Users/dgreenwood/Documents/repos/trek-view/telemetry-injector/metadata/metadata.py", line 147, in create_video_from_images
    m = g_next['GPSDateTime'].split('.')
KeyError: 'GPSDateTime'

We should show a nicer error to user:

"One or more of your images have no GPS metadata. Please remove these and try again."

@himynamesdave himynamesdave added the enhancement New feature or request label Nov 16, 2022
@himynamesdave himynamesdave added this to the 0.1 milestone Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants