fix: flat node structure for else if #199
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now allows `<string> <identifier> ...` forms of concatenations.
Specifically for Neovim which contains code like:
```c
Dictionary nvim_eval_statusline(String str, Dict(eval_statusline) *opts, Arena *arena, Error *err)
FUNC_API_SINCE(8) FUNC_API_FAST
{
...
}
```
|
Idk, this just feels incorrect overall but I understand the reasoning behind it. @maxbrunsfeld? |
amaanq
force-pushed
the
master
branch
2 times, most recently
from
014e8e0
to
212a80f
Compare
|
given the recent improvements to fetching a parent in tree-sitter and neovim, I'm closing this out |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flattens the structure for
else if .... This is sort of a human convenience change, as technically anelse ifis just anifnested in theelseclause... but this will make a nicer tree (though indentation will have to be updated e.g. in nvim-treesitter)Fixes #198