Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify internals of the SCTFE config #5

Open
phbnf opened this issue Sep 13, 2024 · 0 comments
Open

Simplify internals of the SCTFE config #5

phbnf opened this issue Sep 13, 2024 · 0 comments
Labels
enhancement New feature or request
Milestone

Comments

@phbnf
Copy link
Collaborator

phbnf commented Sep 13, 2024

There's a bunch of struct layers inside the SCTFE at the moment, let's simplify this. The first layer of complexity, the protobuf config was removed in trillian-tessera#200. This Issue is a continuation of this one.

ValidateConfig takes a lot of flags as arguments, and validated them. This should probably be move to main.
Right now, it also parses the ExtendedKeyUsage, we might want to move this around.

Then there's SetUpInstance which actually applies some logic on stuff and open the root_pem_file, or parses the oids. Logically, I think that parsing the oids is similar to parsing the ExtendedKeyUsage, so I might group them together.

Also, right now, the Tessera storage cannot be created anywhere else than in SetupInstance because, it needs a signer, and the signer is created in there... because we need a note.Signer for the checkpoint, but not for the SCTs.

Then theres's newLogInfo, and this one is a bit annoying as well because it's the one that as the TimeSource object, which is also used in tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant