Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review and document accessor metadata provenance #69

Open
timstaley opened this issue Mar 31, 2015 · 4 comments
Open

Review and document accessor metadata provenance #69

timstaley opened this issue Mar 31, 2015 · 4 comments
Assignees
Labels

Comments

@timstaley
Copy link

cf https://redmine.astron.nl/lofar_issuetracker/issues/6598

For any given image/observation, we pull in important items of metadata like central frequency, bandwidth, time of observation, etc.

However, we currently don't document exactly how we pull this from different data sources (e.g. FITS, CASA image) - you have to dig into the source to find out the details. It would be nice to review this and briefly write it up in the docstring for each class.

@AntoniaR
Copy link
Contributor

As we will only handle fits images in R7, this is only required for that accessor.

@HannoSpreeuw
Copy link
Collaborator

@suvayu and me have recently reimplemented the DataAccessor class, while keeping issue transientskp/tkp#53 open since some of its derived classes may require redesign.

Moreover, the accessors folder and the corresponding unit tests will be moved from TraP once this PR transientskp/tkp#619 is merged. accessors will persist in PySE, with the unit tests added.

This means we should be adding the required docstrings.
So we could turn this into a PySE issue, but possibly not worth the hassle.

@HannoSpreeuw HannoSpreeuw assigned HannoSpreeuw and suvayu and unassigned timstaley Aug 21, 2024
@AntoniaR
Copy link
Contributor

Great!

It's quick and straightforward to move the issue to PySE if that is useful (I already moved one issue)

@HannoSpreeuw
Copy link
Collaborator

O perhaps that'd be neat. Please do so.

@AntoniaR AntoniaR transferred this issue from transientskp/tkp Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants