This repository has been archived by the owner on Sep 23, 2024. It is now read-only.
Give option to keep CSV files locally and skip upload to S3 #30
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When testing pipelines on a local machine, you don't always need to actually send the files to S3. Sometimes you just want to
verify the data is written correctly to CSV file.
Proposed changes
With this change, specifying the s3_bucket value as 'localhost' will skip the upload to S3 and not remove the files from temp_dir.
It also skips creation of AWS session, avoiding need to have AWS credentials for local testing.
Types of changes
What types of changes does your code introduce to PipelineWise?
Put an
x
in the boxes that applyChecklist
setup.py
is an individual PR and not mixed with feature or bugfix PRs[AP-NNNN]
(if applicable. AP-NNNN = JIRA ID)AP-NNN
(if applicable. AP-NNN = JIRA ID)