-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check authentication tag in penumbra #16
Labels
security-nice
Optional features that improve our security
Comments
Could we add a severity to this issue @bencmbrook or @michaelfarrell76 so we can track it under an SLA? It would be good to assign someone as well for all open |
michaelfarrell76
added
security-nice
Optional features that improve our security
and removed
security
Security
p4
labels
Feb 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Right now we're skipping the authtag verification step, which is a tiny security flaw, because it doesn't verify the signature (see step 3 below), meaning Transcend could tamper with the encrypted bytes passed through (which, worst case, just breaks the file).
All we need to do is:
decipher.final
. This has to happen after decryption. I think new TransformStream takes aclose
argument where this may be possible.This is good to do, because...
The text was updated successfully, but these errors were encountered: