Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to standardize gallery thumbnail size #13

Open
teewhey opened this issue Dec 22, 2017 · 3 comments
Open

Option to standardize gallery thumbnail size #13

teewhey opened this issue Dec 22, 2017 · 3 comments

Comments

@teewhey
Copy link

teewhey commented Dec 22, 2017

image

Hi just wondering if you could consider to provide options to standardize thumbnail sizes. As of now, if i were to upload images with different orientation or aspect ratio, the alignment runs. I was hoping it would do some smart cropping so that I get a standard tile of images irregardless of what aspect ratio.

@tranduyhung
Copy link
Owner

That's the reason I added ability to choose manual thumbnails instead of let Grav automatically crops the images to create the thumbnails.

There is no "smart" cropping, there is only 1 rule and it is applied to all the images, this sometimes create problems, like text in image is cropped and unreadable, heads of people are cut off, etc...

@teewhey
Copy link
Author

teewhey commented Dec 27, 2017

Can you point me to your documentations on how to choose manual thumbnails ? I'm new to PHP and Grav. Still need some time to understand certain stuff.

@tranduyhung
Copy link
Owner

I'm sorry that I should have mentioned that manual thumbnail was a work in progress. I thought of having 2 configuration options to choose between automatic thumbnail (like what the theme has now) and manual thumbnail which let user upload and choose specific thumbnails for all (or only some) of the gallery's images.

There are problems in backward compatibility and styling in front-end. When they are solved there will be a new version available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants