Uncaught ValueError in SEXTEND

[sam-xif]

Summary of the problem

Hello manticore community,

I am working as part of a research team developing a code analysis tool for Python. One of the issues the tool discovered in manticore's codebase is that core.smtlib.operators.SEXTEND has the potential to throw uncaught ValueError. The ValueError is caused by a negative value for the size_src and/or size_dest argument.

If you are interested in learning more about the tool and how it found this issue, let me know down in the comments, or you can contact me at [email protected]. We are primarily curious about whether you find that this issue is legitimate and worth reporting and fixing. If not, we would be interested in understanding why.

Thank you for your consideration!

-Sam

Manticore version

Latest master (commit hash: 8861005)

Python version

Python 3.8

OS / Environment

Linux (kernel version 5.10.218)

Dependencies

N/A

Step to reproduce the behavior

Call SEXTEND with a negative value for the size_src and/or size_dest argument.

Expected behavior

Assertion failure indicating that size_src and size_dest should be nonnegative.

Actual behavior

Traceback:

Traceback (most recent call last):
  ...
  File ".../repos/manticore/manticore/core/smtlib/operators.py", line 139, in SEXTEND
    if x >= (1 << (size_src - 1)):
ValueError: negative shift count

Traceback (most recent call last):
  ...
  File ".../repos/manticore/manticore/core/smtlib/operators.py", line 141, in SEXTEND
    return x & ((1 << size_dest) - 1)
ValueError: negative shift count