Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update hovered source on all crosshair changes #1727

Merged
merged 4 commits into from
Nov 22, 2024

Conversation

illetid
Copy link
Contributor

@illetid illetid commented Nov 13, 2024

Type of PR: enhancement

PR checklist:

Overview of change:

  • moved the hitTest check into the model to update the hovered source on scrollToPosition and other chart changes
  • added hitTest for the arrow markers

Copy link

github-actions bot commented Nov 13, 2024

size-limit report 📦

Path Size
ESM 42.43 KB (+0.27% 🔺)
ESM createChart 36.3 KB (+0.09% 🔺)
ESM createChartEx 35.04 KB (-0.06% 🔽)
ESM Standalone 43.89 KB (+0.19% 🔺)
Standalone 43.84 KB (+0.22% 🔺)
Plugin: Text Watermark 1.86 KB (-0.16% 🔽)
Plugin: Image Watermark 1.68 KB (-0.18% 🔽)
Plugin: Series Markers 3.97 KB (+2.09% 🔺)
Series: LineSeries 2.54 KB (-0.08% 🔽)
Series: BaselineSeries 3.05 KB (-0.29% 🔽)
Series: AreaSeries 2.98 KB (-0.04% 🔽)
Series: BarSeries 2.14 KB (-0.14% 🔽)
Series: CandlestickSeries 2.42 KB (-0.33% 🔽)
Series: HistogramSeries 2.19 KB (-0.23% 🔽)

@illetid illetid marked this pull request as ready for review November 13, 2024 16:28
@SlicedSilver
Copy link
Contributor

Could you try add an interaction e2e test case which would fail on the old code, and pass on this code?
and could you check if this PR addresses any of the other hoveredObjectId bugs in the v5 milestone? 🙏

@illetid
Copy link
Contributor Author

illetid commented Nov 14, 2024

Could you try add an interaction e2e test case which would fail on the old code, and pass on this code? and could you check if this PR addresses any of the other hoveredObjectId bugs in the v5 milestone? 🙏

@SlicedSilver other two bugs #1503 and #1513 were caused by overlapping with price line, and were resolved when we moved series markers into the plugin. I'll add tests for all 3 cases

@illetid illetid self-assigned this Nov 21, 2024
@illetid illetid merged commit 31c601f into v5-candidate Nov 22, 2024
33 checks passed
@illetid illetid deleted the fix/markers-hittest branch November 22, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants