Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asset admin edit form actions #778

Open
mfendeksilverstripe opened this issue Feb 14, 2023 · 4 comments
Open

Asset admin edit form actions #778

mfendeksilverstripe opened this issue Feb 14, 2023 · 4 comments

Comments

@mfendeksilverstripe
Copy link
Contributor

mfendeksilverstripe commented Feb 14, 2023

Asset admin edit form actions

Looks like we don't have a proper locale aware customisation in the Asset admin actions UI in the edit form. This covers the case where content is being inherited from another locale. For example, for pages we would display UI indicating that you can localise the page (copy and copy & publish buttons instead of regular action buttons).

Individual asset actions

Screen Shot 2023-02-15 at 11 32 53 AM

Publish buttons reflects the correct state but the rest of the UI needs tweaking.

  • Save button should be replaced by Copy (Localise) button
  • Publish button should be replaced with Copy (Localise) & publish
  • Localisation manager tab is missing
  • Unpublish and archive buttons need to follow the same rules as for page edit forms (appear only when there is localised content to unpublish or archive)

Localisation badges

Content authors need to know if assets has localised content, inherited content or no content. We can achieve this by adding a badge to the asset card.

Screenshot 2024-02-21 at 3 25 45 PM

Batch actions

Screen Shot 2023-02-15 at 11 33 20 AM

  • these actions should be disabled for this case (inherited content)

Impacted version

All versions (tested on version 6).

@tractorcow
Copy link
Collaborator

From memory, you had to create a custom form builder, or extend the form builder for assets to get custom actions. Is that supported in the new react based forms for assets?

@mfendeksilverstripe
Copy link
Contributor Author

Not sure, this requires further investigation but I think there were some recent improvements to the React based UI. Maybe @maxime-rainville can chime in with some insight ;-)

@tractorcow
Copy link
Collaborator

tractorcow commented Feb 14, 2023

From memory, we could extend form builder, and decorate the actions list. I don't remember how much control it gave over styling / layout / extra menus.

Then we just needed to add the actual action to the AssetAdmin controller (I think there's already a fluent extension that does this for other admins).

@mfendeksilverstripe
Copy link
Contributor Author

Hey @maxime-rainville is this something we can get prioritised?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants