From d72100ec730b62928c0c6f10278ae8ea3864ae59 Mon Sep 17 00:00:00 2001 From: nathaniel Date: Wed, 17 Jul 2024 14:32:06 -0400 Subject: [PATCH] Some fixes --- .github/workflows/publish.yml | 10 ++++---- xtask/src/commands/pull_request_checks.rs | 9 ++----- xtask/src/commands/test.rs | 30 ----------------------- 3 files changed, 7 insertions(+), 42 deletions(-) diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml index fb8ebbca..9a2c7e82 100644 --- a/.github/workflows/publish.yml +++ b/.github/workflows/publish.yml @@ -7,13 +7,13 @@ on: jobs: publish-cubecl-common: - uses: tracel-ai/burn/.github/workflows/publish-template.yml@main + uses: tracel-ai/cubecl/.github/workflows/publish-template.yml@main with: crate: cubecl-common secrets: inherit publish-cubecl-runtime: - uses: tracel-ai/burn/.github/workflows/publish-template.yml@main + uses: tracel-ai/cubecl/.github/workflows/publish-template.yml@main with: crate: cubecl-runtime needs: @@ -21,7 +21,7 @@ jobs: secrets: inherit publish-cubecl-macros: - uses: tracel-ai/burn/.github/workflows/publish-template.yml@main + uses: tracel-ai/cubecl/.github/workflows/publish-template.yml@main with: crate: cubecl-macros needs: @@ -29,7 +29,7 @@ jobs: secrets: inherit publish-cubecl-core: - uses: tracel-ai/burn/.github/workflows/publish-template.yml@main + uses: tracel-ai/cubecl/.github/workflows/publish-template.yml@main with: crate: cubecl-core needs: @@ -38,7 +38,7 @@ jobs: secrets: inherit publish-cubecl: - uses: tracel-ai/burn/.github/workflows/publish-template.yml@main + uses: tracel-ai/cubecl/.github/workflows/publish-template.yml@main with: crate: cubecl needs: diff --git a/xtask/src/commands/pull_request_checks.rs b/xtask/src/commands/pull_request_checks.rs index 415eecc5..cabdac26 100644 --- a/xtask/src/commands/pull_request_checks.rs +++ b/xtask/src/commands/pull_request_checks.rs @@ -1,9 +1,6 @@ use strum::IntoEnumIterator; -use super::{ - ci::{self, CICmdArgs, CICommand}, - test::run_guide, -}; +use super::ci::{self, CICmdArgs, CICommand}; pub(crate) fn handle_command() -> anyhow::Result<()> { CICommand::iter() @@ -14,7 +11,5 @@ pub(crate) fn handle_command() -> anyhow::Result<()> { target: super::Target::All, command: c.clone(), }) - })?; - // Execute the guide example - run_guide() + }) } diff --git a/xtask/src/commands/test.rs b/xtask/src/commands/test.rs index c1effb15..5503c8f2 100644 --- a/xtask/src/commands/test.rs +++ b/xtask/src/commands/test.rs @@ -11,9 +11,6 @@ use crate::{ use super::Target; -const PROJECT_UUID: &str = "331a3907-bfd8-45e5-af54-1fee73a3c1b1"; -const API_KEY: &str = "dcaf7eb9-5acc-47d7-8b93-ca0fbb234096"; - #[derive(Args)] pub(crate) struct TestCmdArgs { /// Target to test for. @@ -32,8 +29,6 @@ enum TestCommand { Integration, /// Run documentation tests. Documentation, - /// Run guide test against Heat dev stack. - Guide, /// Run all the checks. All, } @@ -43,7 +38,6 @@ pub(crate) fn handle_command(args: TestCmdArgs) -> anyhow::Result<()> { TestCommand::Unit => run_unit(&args.target), TestCommand::Integration => run_integration(&args.target), TestCommand::Documentation => run_documentation(&args.target), - TestCommand::Guide => run_guide(), TestCommand::All => TestCommand::iter() .filter(|c| *c != TestCommand::All) .try_for_each(|c| { @@ -55,30 +49,6 @@ pub(crate) fn handle_command(args: TestCmdArgs) -> anyhow::Result<()> { } } -pub(crate) fn run_guide() -> Result<()> { - group!("Guide Test"); - info!("Command line: cargo run --release --bin guide -- --key \"...\" --project \"...\""); - let status = Command::new("cargo") - .args([ - "run", - "--release", - "--bin", - "guide", - "--", - "--key", - API_KEY, - "--project", - PROJECT_UUID, - ]) - .status() - .map_err(|e| anyhow!("Failed to execute guide example: {}", e))?; - if !status.success() { - return Err(anyhow!("Failed to execute guide example")); - } - endgroup!(); - Ok(()) -} - pub(crate) fn run_unit(target: &Target) -> Result<()> { match target { Target::Crates | Target::Examples => {