Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add select method for bool tensors #2560

Open
poshcoe opened this issue Nov 28, 2024 · 0 comments
Open

Add select method for bool tensors #2560

poshcoe opened this issue Nov 28, 2024 · 0 comments
Labels
enhancement Enhance existing features

Comments

@poshcoe
Copy link

poshcoe commented Nov 28, 2024

Feature description

Expose select and select_assign tensor operations for boolean tensors.

At the moment the select and select_assign methods are within the Numeric trait, however the functionality is also useful for boolean tensors (and I don't think there are any numeric requirements to its implementation)

Feature motivation

The select method is very handy for float and int tensors. Bool tensors have been left out!

Suggest a Solution

My high level suggestion is moving these methods to the BasicOps trait.

@nathanielsimard nathanielsimard added the enhancement Enhance existing features label Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhance existing features
Projects
None yet
Development

No branches or pull requests

2 participants