Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GetQuestionnairesQueryParam.Sortにキーワードを追加 #998

Closed
wants to merge 4 commits into from

Conversation

H1rono
Copy link
Member

@H1rono H1rono commented Jan 1, 2023

#877 のバックエンド実装です
/api/questionnairessortクエリに↓のキーワードを追加しました

  • res_time_limit, -res_time_limit
  • response_count, -response_count
  • last_response_at, -last_response_at

- res_time_limit, -res_time_limit
- response_count, -response_count
- last_response_at, -last_response_at
@H1rono H1rono self-assigned this Jan 1, 2023
@xxarupakaxx
Copy link
Contributor

xxarupakaxx commented Jan 1, 2023

prありがとうございます!!助かります🙏
1/5ごろまでpc触れないのでレビュは他の方お願いしたいです
@MotoyaAsahina 時間取れるのならレビューお願いします!

それと、開発環境をローカルで立ち上げるにはこちらをみるといいと思います〜

https://wiki.trap.jp/SysAd/dev/anke-to

確かローカルでテストをするにはmake testで実行できます

@H1rono H1rono removed their assignment Mar 26, 2023
Copy link
Member

@mazrean mazrean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

方針はokなのですが、いくつか気になった箇所があったのでコメントしました。
あと、以下のswaggerも変更しないと実装と仕様のずれが発生してしまうので、swaggerも変更した方がよさそうです。
https://github.com/traPtitech/anke-to/blob/392395c940cceb44f84cd2f97409bbad11acbd75/docs/swagger/swagger.yaml

model/questionnaires_impl.go Show resolved Hide resolved
model/questionnaires_impl.go Outdated Show resolved Hide resolved
@H1rono H1rono requested a review from mazrean June 1, 2023 06:16
@codecov
Copy link

codecov bot commented Jun 1, 2023

Codecov Report

Patch coverage: 4.76% and project coverage change: -0.39 ⚠️

Comparison is base (75dda75) 60.41% compared to head (681dafc) 60.02%.

❗ Current head 681dafc differs from pull request most recent head a0aa016. Consider uploading reports for the commit a0aa016 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #998      +/-   ##
==========================================
- Coverage   60.41%   60.02%   -0.39%     
==========================================
  Files          20       20              
  Lines        2981     3002      +21     
==========================================
+ Hits         1801     1802       +1     
- Misses       1020     1040      +20     
  Partials      160      160              
Impacted Files Coverage Δ
router/questionnaires.go 53.22% <ø> (ø)
model/questionnaires_impl.go 70.63% <4.76%> (-4.07%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants