-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GetQuestionnairesQueryParam.Sortにキーワードを追加 #998
Conversation
- res_time_limit, -res_time_limit - response_count, -response_count - last_response_at, -last_response_at
prありがとうございます!!助かります🙏 それと、開発環境をローカルで立ち上げるにはこちらをみるといいと思います〜 https://wiki.trap.jp/SysAd/dev/anke-to 確かローカルでテストをするにはmake testで実行できます |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
方針はokなのですが、いくつか気になった箇所があったのでコメントしました。
あと、以下のswaggerも変更しないと実装と仕様のずれが発生してしまうので、swaggerも変更した方がよさそうです。
https://github.com/traPtitech/anke-to/blob/392395c940cceb44f84cd2f97409bbad11acbd75/docs/swagger/swagger.yaml
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #998 +/- ##
==========================================
- Coverage 60.41% 60.02% -0.39%
==========================================
Files 20 20
Lines 2981 3002 +21
==========================================
+ Hits 1801 1802 +1
- Misses 1020 1040 +20
Partials 160 160
☔ View full report in Codecov by Sentry. |
#877 のバックエンド実装です
/api/questionnaires
のsort
クエリに↓のキーワードを追加しましたres_time_limit
,-res_time_limit
response_count
,-response_count
last_response_at
,-last_response_at