From df01597e70a4b46da63491328642673526233695 Mon Sep 17 00:00:00 2001 From: Sukrit Khera Date: Tue, 8 Mar 2016 12:24:11 -0700 Subject: [PATCH 1/3] Ability to disable discover check Ability to disable discover check (Use 0 for check port to disable discover check) --- schemas/app-version-v1.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/schemas/app-version-v1.json b/schemas/app-version-v1.json index 28e67a2..6425584 100644 --- a/schemas/app-version-v1.json +++ b/schemas/app-version-v1.json @@ -110,8 +110,8 @@ }, "port": { "type": "number", - "description": "Application internal Port to be used for discover check", - "minimum": 1 + "description": "Application internal Port to be used for discover check (Use 0 to disable discover check)", + "minimum": 0 }, "path": { "type": "string", From ecdaf99636bc36f0bc87c50f24d2ef7679bdf177 Mon Sep 17 00:00:00 2001 From: Sukrit Khera Date: Tue, 8 Mar 2016 12:26:13 -0700 Subject: [PATCH 2/3] Bump to next dev version --- deployer/__init__.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/deployer/__init__.py b/deployer/__init__.py index 04e8f24..0fc0396 100644 --- a/deployer/__init__.py +++ b/deployer/__init__.py @@ -3,7 +3,7 @@ from celery.signals import setup_logging -__version__ = '0.4.5' +__version__ = '0.4.6' __author__ = 'sukrit' deployer.logger.init_logging() From 944e320a472e381b49edb55db1d783ddd9af684c Mon Sep 17 00:00:00 2001 From: Sukrit Khera Date: Tue, 8 Mar 2016 13:30:49 -0700 Subject: [PATCH 3/3] Disable port checking for if 0 Disable port checking for if 0 --- deployer/tasks/deployment.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/deployer/tasks/deployment.py b/deployer/tasks/deployment.py index 241476c..7e0aa62 100644 --- a/deployer/tasks/deployment.py +++ b/deployer/tasks/deployment.py @@ -120,8 +120,8 @@ def _check_discover(self, app_name, app_version, check_port, min_nodes, :return: discovered nodes :rtype: dict """ - if check_port is None: - # Skip discover if port is not passed + if not check_port: + # Skip discover if port is empty, 0 , None return {} discovered_nodes = get_discovered_nodes(app_name, app_version, check_port,