Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop other ICMP packets? #1

Open
CristianCantoro opened this issue Apr 28, 2016 · 1 comment
Open

Drop other ICMP packets? #1

CristianCantoro opened this issue Apr 28, 2016 · 1 comment

Comments

@CristianCantoro
Copy link

I am not an expert, but shouldn't we add the following rule:

-A INPUT -p icmp -j DROP

at line 34 in iptables.test.rules to block all other ICMP packets.

@moba
Copy link
Member

moba commented Apr 29, 2016

Hmm. You're right that in the current form, explicitly listing some ICMP packet types does not really make sense. In doubt I would rather remove the ICMP filtering altogether and simply allow all ICMP. One could also think about rate limiting and specifically filtering out certain types of requests. As it stands, the configuration allows any ICMP requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants