Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Review and Re-organize tests #304

Open
6 tasks
dopry opened this issue Jan 17, 2023 · 0 comments
Open
6 tasks

Proposal: Review and Re-organize tests #304

dopry opened this issue Jan 17, 2023 · 0 comments

Comments

@dopry
Copy link
Collaborator

dopry commented Jan 17, 2023

Many of the tests are currently organized around the features of the example site (test_blog, test_general, etc) and not really around the features of the grapple library. There are multiple tests that cover pagination in test_grapple, test_blog, and test_general. These tests seem to favor ensuring complete coverage of the example app rather than simply covering all the cases of grapple. This creates redundant work for grapple test maintenance.

It would be nice to structure a suite of unit tests and integration tests with minimal overlap that provide complete coverage of the documented features rather than focusing on the example site. This process should probably be take in several steps.

A possible roadmap:

  1. re-organize example into 'testapp`, Package re-organisation #289
  2. implement code coverage tracking
  3. identify and remove redundant tests
  4. add tests to complete unit test coverage
  5. add tests to complete integration test coverage (testapp tests)
  6. review test naming to make more consistent.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant