Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

American vs. British spelling for color variables #15

Open
thibaudcolas opened this issue Mar 14, 2022 · 0 comments
Open

American vs. British spelling for color variables #15

thibaudcolas opened this issue Mar 14, 2022 · 0 comments
Labels
help wanted Extra attention is needed
Milestone

Comments

@thibaudcolas
Copy link
Member

thibaudcolas commented Mar 14, 2022

This project’s Sass variables for color use the british colour spelling:

$tbxforms-error-colour: #d4351c !default;
$tbxforms-text-colour: #0b0c0c !default;
$tbxforms-print-text-colour: #000 !default;
$tbxforms-secondary-text-colour: #505a5f !default;
$tbxforms-border-colour-conditional: #b1b4b6 !default;
$tbxforms-input-border-colour: $tbxforms-text-colour !default;
$tbxforms-hover-colour: #b1b4b6 !default;
$tbxforms-focus-colour: #ffbf47 !default;
$tbxforms-active-bg: #444 !default;
$tbxforms-active-colour: #fff !default;
.

This is to match the govuk-frontend naming, which clashes with our usual style of using American spelling for Sass/CSS variables. Our style is due to the CSS language using the American spelling for CSS keywords (background-color).

@thibaudcolas thibaudcolas added the help wanted Extra attention is needed label Mar 14, 2022
@thibaudcolas thibaudcolas added this to the Nice to have milestone Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant