You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have filled out the issue template to the best of my ability.
This issue only contains 1 issue (if you have multiple issues, open one issue for each issue).
This issue is not a duplicate issue of currently previous issues..
Describe the issue
If the Maximum charge (w) value is changed via the Service E3DC Remote Storage Control Protocol (Git): Set power limits, the Minimum required discharge value is always reset to 100W.
Reproduction steps
change the Minimum required discharge value (Untere Entladeschwelle) via E3DC Portal or RSCPGui for Exempel to 50W
take the Home Assistant service E3DC Remote Storage Control Protocol (Git): Set power limits and set withe that the Maximum Charge (Maximale Ladeleistung) value to for expampel 3000W
Now take a look back at the Minimum required discharge value (Untere Entladeschwelle) and it will be back at 100W
thobohoii
changed the title
Action E3DC Remote Storage Control Protocol (Git): Set power limits
Service E3DC Remote Storage Control Protocol (Git): Set power limits
Sep 2, 2024
I was able to reproduce the issue.
The Service (or now-called action since HA 2024.8) called the underlying pye3dc with "None" for the non-set / non-changed values. pye3dc writes the system default value to the limits (max_charge, max_discharge, min_discharge) when called with None. Meaning when only changing one of max_charge or max_discharge, the other one would be reset to the system value as well in addition to min_discharge.
To fix this, i changed the service that when the values of one of these three limits are not changed, the currently set value is taken and written (again) via pye3dc to the Hauskraftwerk to preserve the current values.
(The only other option would be the re-implementation of pye3dc's set_power_limits() which seemed like overkill to me)
This by the way introduces the option to change min_discharge as well via HA, which wasn't possible previously.
One implication of this bug fix is a change in behaviour of the service. previously, you could (mis)use this service to re-set limits to their default values. now you striclty have to use "clear power limits" to clear all three of them.
However i think this fix makes sense and is more logical than it was before.
@torbennehmer - let's discuss if you think the issue raised by @thobohoii should be handled differently.
@bullitt186 thank you for your investigation.
Something like that was also my thougth. But i am not the programing guy.
I also tright difrent variations of the Service. Just max_charge or just max_discharge or both. But always the min_discharge Value will be reset to 100W.
System Health details
System Information
Home Assistant Community Store
Home Assistant Cloud
Home Assistant Supervisor
Dashboards
Recorder
Checklist
Describe the issue
If the Maximum charge (w) value is changed via the Service E3DC Remote Storage Control Protocol (Git): Set power limits, the Minimum required discharge value is always reset to 100W.
Reproduction steps
Debug logs
Diagnostics dump
No response
The text was updated successfully, but these errors were encountered: