test "Good names for dummies with reocurring patterns" fails sometimes

[MichaelChirico]

Our CI sees the caret suite fail occasionally. I think the test needs to set a seed, or otherwise the code needs to be designed to be robust to random input (at a glance, I am guessing the former).

caret/pkg/caret/tests/testthat/test_Dummies.R

Lines 122 to 139 in 5f4bd20

	test_that("Good names for dummies with reocurring patterns", {
	data = data.frame(
	matrix(
	rep(
	as.factor(sample.int(15, size = 100, replace = TRUE, prob = rep(1 / 15, 15))
	),
	15
	),
	ncol = 15
	),
	stringsAsFactors = TRUE
	)
	essai_dummyVars = caret::dummyVars(stats::as.formula(paste0("~ ", colnames(data), collapse = "+")), data)
	exp_names_lvls <- apply(expand.grid(paste0("X",1:15), paste0(".",1:15)), 1, paste, collapse="")
	res_names_lvls <- colnames(predict(essai_dummyVars, data))
	expect_true(all(exp_names_lvls %in% res_names_lvls))
	})

replicate(1e4, {
test_that("Good names for dummies with reocurring patterns", {
  data = data.frame(
    matrix(
      rep(
        as.factor(sample.int(15, size = 100, replace = TRUE, prob = rep(1 / 15, 15))
        ),
        15
      ),
      ncol = 15
    ),
    stringsAsFactors = TRUE
  )
  essai_dummyVars = caret::dummyVars(stats::as.formula(paste0("~ ", colnames(data), collapse = "+")), data)

  exp_names_lvls <- apply(expand.grid(paste0("X",1:15), paste0(".",1:15)), 1, paste, collapse="")
  res_names_lvls <- colnames(predict(essai_dummyVars, data))
  expect_true(all(exp_names_lvls %in% res_names_lvls))
})
})

The failure looks like it happens <1% of the time, but the 1e4 replications I used above seems to trigger the issue consistently.