From f52482f5516cc7837065530603083b213ffa9536 Mon Sep 17 00:00:00 2001
From: bountyCoder <bountyc0d3r@gmail.com>
Date: Wed, 30 Nov 2022 18:50:36 +0000
Subject: [PATCH] removed caching while getting groups

---
 src/services/groups.js | 32 +++++++++++++++++++-------------
 1 file changed, 19 insertions(+), 13 deletions(-)

diff --git a/src/services/groups.js b/src/services/groups.js
index 2ba8b98..1a672a9 100644
--- a/src/services/groups.js
+++ b/src/services/groups.js
@@ -320,26 +320,32 @@ class GroupService {
    * @return {Promise} Resolves to ID array.
    */
   async getGroupTreeIds(rootGroupId, maxage = 5 * 60 * 1000) {
-    const now = Date.now();
-    const cache = this.private.cache.groupTreeIds;
+    //TODO: Once the fix is validated and working, remove all commented code related to caching
+    /**
+     * Removing the caching mechanism, 
+     * as the group created on the day will only be pickedup on the next day
+     * and stored in the cache
+     */
+    // const now = Date.now();
+    // const cache = this.private.cache.groupTreeIds;
 
     /* Clean-up: removes stale records from the cache. */
-    const CLEAN_UP_INTERVAL = 24 * 60 * 60 * 1000; // 1 day in ms.
-    if (now - cache.lastCleanUp > CLEAN_UP_INTERVAL) {
-      _.forOwn(cache, ({ timestamp }, key) => {
-        if (now - timestamp > CLEAN_UP_INTERVAL) delete cache[key];
-      });
-      cache.lastCleanUp = now;
-    }
+    // const CLEAN_UP_INTERVAL = 24 * 60 * 60 * 1000; // 1 day in ms.
+    // if (now - cache.lastCleanUp > CLEAN_UP_INTERVAL) {
+    //   _.forOwn(cache, ({ timestamp }, key) => {
+    //     if (now - timestamp > CLEAN_UP_INTERVAL) delete cache[key];
+    //   });
+    //   cache.lastCleanUp = now;
+    // }
 
     /* If result is found in cache, and is fresh enough, return it. */
-    const cached = cache[rootGroupId];
-    if (cached && now - cached.timestamp < maxage) return _.clone(cached.data);
+    // const cached = cache[rootGroupId];
+    // if (cached && now - cached.timestamp < maxage) return _.clone(cached.data);
 
     /* Otherwise, fetch result from the API, write it to the cache, and
      * finally return that. */
     const res = reduceGroupIds(await this.getGroup(rootGroupId));
-    cache[rootGroupId] = { data: res, timestamp: now };
+    // cache[rootGroupId] = { data: res, timestamp: now };
     return _.clone(res);
   }
 
@@ -409,4 +415,4 @@ export function getService(tokenV3) {
   return lastInstance;
 }
 
-export default undefined;
+export default undefined;
\ No newline at end of file