Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Member Search to the New Nav #73

Closed
SathyaJayabal opened this issue Dec 23, 2019 · 13 comments
Closed

Adding Member Search to the New Nav #73

SathyaJayabal opened this issue Dec 23, 2019 · 13 comments
Assignees
Labels

Comments

@SathyaJayabal
Copy link
Collaborator

  1. Adding member search to the new nav
@SathyaJayabal
Copy link
Collaborator Author

@luizrrodrigues, On testing the member search on beta:
Search functionality works fine. There were just a couple of minor issues.

  1. Search results page is displayed in prod. The search results page does not have the new nav.

Screenshot 2020-01-07 at 7 33 00 PM

2. The search icon seems too much in the right corner. You can see the old search icon had more space to the right.

Screenshot 2020-01-07 at 7 40 05 PM

Screenshot 2020-01-07 at 7 40 39 PM

3.The current page selection indicator looks a bit odd when search panel is displayed.

Screenshot 2020-01-07 at 7 41 45 PM

@luizrrodrigues
Copy link
Collaborator

@SathyaJayabal Let me know if test is done, so we request to fix these minor issues.

cc @nithyaasworld

@SathyaJayabal
Copy link
Collaborator Author

@luizrrodrigues , let me do a quick smoke test on beta and will let you know.

@SathyaJayabal
Copy link
Collaborator Author

@luizrrodrigues, i dont see any other issues other than the ones mentioned above

@nithyaasworld
Copy link
Collaborator

@luizrrodrigues Just like to add that we coulnd't verify the fix because of the issue stated in No:1 point added by Sathya here #73 (comment)

Also if we change the production URL to beta URL, we get this error. Can you check once please?
image

cc: @SathyaJayabal

@luizrrodrigues
Copy link
Collaborator

@nithyaasworld

  1. Is like related here: Some pages are not having the New Navigation community-app#2670
    Search results looks like a different app.

@sushilshinde can you confirm that?

@luizrrodrigues
Copy link
Collaborator

@luizrrodrigues
Copy link
Collaborator

  1. and 3. was fixed and deployed in Beta/Test servers.

@SathyaJayabal
Copy link
Collaborator Author

@luizrrodrigues, 2 and 3 looks good
Screenshot 2020-01-10 at 5 08 02 PM

@SathyaJayabal
Copy link
Collaborator Author

@luizrrodrigues , @sushilshinde

What do you think of the background of the search box in the mobile view? Should it be dark? Or is this the expected design ?

Screenshot 2020-01-10 at 5 37 52 PM

@SathyaJayabal
Copy link
Collaborator Author

@luizrrodrigues , do we have a design document to refer to?

@luizrrodrigues
Copy link
Collaborator

@SathyaJayabal I think we'll follow like desktop version colors.

You'll open a new issue followup this one?

@SathyaJayabal
Copy link
Collaborator Author

@luizrrodrigues , yes I have.
#100

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants