Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$40 | New Nav: Page should not reload when navigating between menus #36

Open
nithyaasworld opened this issue Jun 18, 2019 · 37 comments · Fixed by #37
Open

$40 | New Nav: Page should not reload when navigating between menus #36

nithyaasworld opened this issue Jun 18, 2019 · 37 comments · Fixed by #37
Assignees
Labels

Comments

@nithyaasworld
Copy link
Collaborator

In the New nav, when navigating between different menus, currently the total page is getting reloaded including the nav bar.

Expected: When navigating between different menus, The top navigation bar should remain static and only the content area should get refreshed with corresponding data.

@luizrrodrigues luizrrodrigues changed the title New Nav: Page should not reload when navigating between menus $40 | New Nav: Page should not reload when navigating between menus Jun 18, 2019
@r0hit-gupta
Copy link
Collaborator

May I assign this to myself?

@luizrrodrigues
Copy link
Collaborator

@r0hit-gupta yes, thanks.

@luizrrodrigues
Copy link
Collaborator

Assigned to @r0hit-gupta

@r0hit-gupta
Copy link
Collaborator

It says Unauthorized whenever I click some link present on the header. I already logged in using the test credentials - dan_developer. How do I resolve this?

@luizrrodrigues
Copy link
Collaborator

luizrrodrigues commented Jun 19, 2019

@r0hit-gupta Need set CONTENTFUL KEYS, please check here:
https://apps.topcoder.com/forums/?module=Thread&threadID=938763&start=0&mc=1

If you not able to access forum, please register in this challenge:
https://www.topcoder.com/challenges/30092991/?type=develop

@r0hit-gupta
Copy link
Collaborator

Thanks @luizrrodrigues. The app loads fine now. However, upon closer inspection I believe the actual bug lies in the navigation-component. It uses <a> tags instead of <Link> tags which will always trigger a complete page reload. Should I make a PR on that repository?

@luizrrodrigues
Copy link
Collaborator

Yes, please send PR to navigation-component if needed. Thanks

@r0hit-gupta
Copy link
Collaborator

@luizrrodrigues sure. By the way it's late here. Do you mind if I do it in the morning?

@luizrrodrigues
Copy link
Collaborator

luizrrodrigues commented Jun 19, 2019 via email

@r0hit-gupta
Copy link
Collaborator

Unable to resolve the issue. Opening up for others.

@luizrrodrigues
Copy link
Collaborator

@r0hit-gupta Okay, no problem. Thanks try that.

@gets0ul
Copy link
Collaborator

gets0ul commented Jun 20, 2019

Can I work on this?
Thanks.

@luizrrodrigues
Copy link
Collaborator

@gets0ul Yes, thanks.

@gets0ul
Copy link
Collaborator

gets0ul commented Jun 21, 2019

@luizrrodrigues It's been over 12 hours, you can unassign me from this. Thanks.

@luizrrodrigues
Copy link
Collaborator

@gets0ul Okay, thanks for trying.

@lucyji1000
Copy link

May I give this a try? @luizrrodrigues

@luizrrodrigues
Copy link
Collaborator

@lucyji1000 Yes, please.

@lucyji1000
Copy link

Opened a PR for this issue here

@gets0ul
Copy link
Collaborator

gets0ul commented Jun 22, 2019

@luizrrodrigues Can I work on this again? I want to give it another try. Thanks.

@luizrrodrigues
Copy link
Collaborator

@gets0ul Yes, sure.

@gets0ul
Copy link
Collaborator

gets0ul commented Jun 22, 2019

@luizrrodrigues PR is submitted.
#33

@luizrrodrigues
Copy link
Collaborator

@gets0ul Thanks, I'll check shortly

@luizrrodrigues
Copy link
Collaborator

@gets0ul #33 (review)

@gets0ul
Copy link
Collaborator

gets0ul commented Jun 24, 2019

@luizrrodrigues PR is updated. Thanks

@luizrrodrigues
Copy link
Collaborator

@gets0ul Please can you merge latest change and rebuild to fix conflicts?
Thanks.

@luizrrodrigues luizrrodrigues transferred this issue from topcoder-platform/community-app Jun 24, 2019
@luizrrodrigues luizrrodrigues added the P1 Urgent (resolve within 24 hours) label Jun 24, 2019
@gets0ul gets0ul mentioned this issue Jun 24, 2019
@gets0ul
Copy link
Collaborator

gets0ul commented Jun 24, 2019

New PR without conflict is submitted. Thanks.

@luizrrodrigues
Copy link
Collaborator

@gets0ul Thanks

@nithyaasworld
Copy link
Collaborator Author

Hi @luizrrodrigues Can you please check this?

This issues seems to be present still, in both logged in and logged out state.

@nithyaasworld nithyaasworld reopened this Jul 1, 2019
@luizrrodrigues
Copy link
Collaborator

@nithyaasworld Yep, this working well.
Maybe you thinking about pages refresh because menu have animation and this reset in all interaction.
(Working on that)

But you can check this working in browser inspector.

@nithyaasworld
Copy link
Collaborator Author

Maybe you thinking about pages refresh because menu have animation and this reset in all interaction.
(Working on that)

Yes, right!

Ok, I will wait for it.

@nithyaasworld
Copy link
Collaborator Author

@luizrrodrigues Please also confirm the below scenario will also be handled as part of this.

Steps:

  1. Go to /challenges (without logging in)
  2. Go to Tracks --> Competitive Programming
  3. Observe that the top level menus are collapsed.

image

@nithyaasworld
Copy link
Collaborator Author

@luizrrodrigues Another Scenario for the above issue:

  1. Go to /challenges (without logging in)
  2. Go to Community --> Tracks
  3. Observe that the top level menus are collapsed.

image

@luizrrodrigues
Copy link
Collaborator

@nithyaasworld I think we can close this again.

@SathyaJayabal
Copy link
Collaborator

Verified

@SathyaJayabal SathyaJayabal reopened this Dec 16, 2019
@SathyaJayabal SathyaJayabal added P3 Normal (resolved within 7 days) and removed P1 Urgent (resolve within 24 hours) labels Dec 16, 2019
@SathyaJayabal
Copy link
Collaborator

@luizrrodrigues the menu animation gets reset whenever we navigate between menu items in the level 1 and level 2 menus. please see the video.
Uploading menu animation.mov.zip…

I am reducing the priority as this is a minor issue.

@luizrrodrigues
Copy link
Collaborator

@SathyaJayabal Please can you open a new ticket to this one, because not related with origin issue in this ticket.

This ticket was related with page reloading issue, this was fixed.

The issue reported above is about menu animation.

Thanks.

@SathyaJayabal
Copy link
Collaborator

@luizrrodrigues OK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants