-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
$40 | New Nav: Page should not reload when navigating between menus #36
Comments
May I assign this to myself? |
@r0hit-gupta yes, thanks. |
Assigned to @r0hit-gupta |
It says |
@r0hit-gupta Need set CONTENTFUL KEYS, please check here: If you not able to access forum, please register in this challenge: |
Thanks @luizrrodrigues. The app loads fine now. However, upon closer inspection I believe the actual bug lies in the |
Yes, please send PR to navigation-component if needed. Thanks |
@luizrrodrigues sure. By the way it's late here. Do you mind if I do it in the morning? |
We need move this ASAP.
|
Unable to resolve the issue. Opening up for others. |
@r0hit-gupta Okay, no problem. Thanks try that. |
Can I work on this? |
@gets0ul Yes, thanks. |
@luizrrodrigues It's been over 12 hours, you can unassign me from this. Thanks. |
@gets0ul Okay, thanks for trying. |
May I give this a try? @luizrrodrigues |
@lucyji1000 Yes, please. |
Opened a PR for this issue here |
@luizrrodrigues Can I work on this again? I want to give it another try. Thanks. |
@gets0ul Yes, sure. |
@luizrrodrigues PR is submitted. |
@gets0ul Thanks, I'll check shortly |
@luizrrodrigues PR is updated. Thanks |
@gets0ul Please can you merge latest change and rebuild to fix conflicts? |
New PR without conflict is submitted. Thanks. |
@gets0ul Thanks |
Hi @luizrrodrigues Can you please check this? This issues seems to be present still, in both logged in and logged out state. |
@nithyaasworld Yep, this working well. But you can check this working in browser inspector. |
Yes, right! Ok, I will wait for it. |
@luizrrodrigues Please also confirm the below scenario will also be handled as part of this. Steps:
|
@luizrrodrigues Another Scenario for the above issue:
|
@nithyaasworld I think we can close this again. |
Verified |
@luizrrodrigues the menu animation gets reset whenever we navigate between menu items in the level 1 and level 2 menus. please see the video. I am reducing the priority as this is a minor issue. |
@SathyaJayabal Please can you open a new ticket to this one, because not related with origin issue in this ticket. This ticket was related with page reloading issue, this was fixed. The issue reported above is about menu animation. Thanks. |
@luizrrodrigues OK. |
In the New nav, when navigating between different menus, currently the total page is getting reloaded including the nav bar.
Expected: When navigating between different menus, The top navigation bar should remain static and only the content area should get refreshed with corresponding data.
The text was updated successfully, but these errors were encountered: