Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issues with right to left languages for iOS 7 and 8 #73

Open
joshuafeldman opened this issue Mar 10, 2016 · 1 comment
Open

Issues with right to left languages for iOS 7 and 8 #73

joshuafeldman opened this issue Mar 10, 2016 · 1 comment

Comments

@joshuafeldman
Copy link

So the issue is that UIStackView was not introduced until iOS 9 and iOS 9 flips all the native controls for right to left languages. So using .Leading and .Trailing is correct since it will respect the language direction. But for iOS 7 and 8 where the user interface direction is not swapped using .Leading and .Trailing is not really appropriate. It should probably be using .Left and .Right. Another small issue is that .Leading and .Trailing is not technically supported in iOS 7.

I am thinking maybe TZStackView needs a .Left and .Right alignment option. Or the class can just handle using the desired layout attribute by iOS version.
joshuafeldman added a commit to joshuafeldman/TZStackView that referenced this issue Mar 10, 2016
@joshuafeldman
Issue tomvanzummeren#73 - Issues with right to left languages for iOS…
ea827b2 
… 7 and 8 - Using .Left and .Right for anything less than iOS 9 instead of .Leading and .Trailing
@joshuafeldman
Copy link
Author

This issue is probably pretty specific to different people's usage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@joshuafeldman