Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: same data conversion in transmit as in read method #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

botmonster
Copy link

It took me some time to debug this. Transfer method worked pretty random when list of integers were converted literally to such string: "[1, 2, 3]" not to binary string :)

@tomstokes
Copy link
Owner

Hey botmonster, thanks for the pull request, and I'm sorry the interface threw you off at first.

I originally designed this whole package as a cleaner drop-in replacement for another system that used the same read/write interface included here and unfortunately the quirks carried over as well.

But you're right in that this should be cleaned up to make more sense in the general case. Let me spend some time on getting this sorted out and making the documentation match as well. Thanks for the input

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants