Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What's the state of this project? #10

Open
martaver opened this issue Mar 25, 2018 · 10 comments
Open

What's the state of this project? #10

martaver opened this issue Mar 25, 2018 · 10 comments

Comments

@martaver
Copy link

I'm having a hard time trying to get a sense of how usable this project is. I've played with your luis-jest and luis-catalogue repos, and I get the impression that things are mostly a work in progress. The 'package mode' isn't making sense to me - is it supposed to run out of 'node_modules' folder?

@martaver
Copy link
Author

Hey man, I'm failing pretty hard at getting this integrated with an existing fuse-box/ts project. Would you mind helping me? I'd like to use this in our project with jest and all the trimmings. If I can just get it rolling I could even contribute to get this to a point where it can be installed with the same ease as storybook. But currently, I can't even get the example in the luis repo running.

@tomitrescak
Copy link
Owner

Hi, I was super busy these days with other activities.
I am confident with the way luis now works but I understand that making it work is pain in the ...

I shall have more time next week to put it to less painful state. From that moment on, I will start advertising it and try to find collaborators. I will keep you posted!

@martaver
Copy link
Author

martaver commented May 2, 2018 via email

@tomitrescak
Copy link
Owner

Hey, some time next week I already have a plan and idea how to simplify the whole thing. Pretty much I will export Luis as a React component that you will be able to plug in anywhere you like. You can set it up as a separate website, as well as use it under some route (e.g. /luis) in your running program. There are other simplifications that I have in mind. I'll let you know once it is finished.

I am happy with the way it works now, as previously I was actually trying to execute tests in the browser and also to create snapshots in the browser. While this was SUPER fast and worked amazingly well, there were inconsistencies between snapshots and test results from console and CI. As a result the solution now works with a test running in JEST or MOCHA in the background and jest picking up test results as they come.

If you do not care about test results, setting up only the "storybook" part of it is even simpler. I will work on the docs as well.

@martaver
Copy link
Author

martaver commented May 3, 2018 via email

@tomitrescak
Copy link
Owner

Frankly, I have used it only with React as I have never worked with Angular and Vue.

From what I understand the Vue integration is seamless with React:
https://github.com/akxcv/vuera

But Angular is yet another bit.h to tackle. We may look into that later.

@tomitrescak
Copy link
Owner

Hi, I have updated the project to simplify its use. I have also updated documentation.

What still remains is to revisit the Luis plugin for VSCODE.

But, now it works really well with both jest and Mocha.

@tomitrescak
Copy link
Owner

tomitrescak commented May 19, 2018

Coming to think about it, also a standalone mode is TODO, where you execute luis as binary, but I don't know how to solve the fuse file, where everyone is using their own config with own plugins.

[EDIT] Probably like this https://storybook.js.org/configurations/custom-webpack-config/

@wmathes
Copy link

wmathes commented Sep 13, 2018

love the project, once you're looking for contributors, hit me up :)

@tomitrescak
Copy link
Owner

@wmathes thanks for the kind words. I'm in the middle of work craze right now, so not much time and love for OS.

I'd be more then glad for any contributions. Project is now kind of stable and works as expected. I went through several rounds to get here but now I'm using it already with 4th project of mine and very happy. What would maybe help is a bit of promotion, e.g. a blog post or anything that would let people know that this is lying around here ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants