Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Rubrik::Sign param from public_key to certificate #6

Merged
merged 1 commit into from
Oct 22, 2023

Conversation

tomascco
Copy link
Owner

The old name was conceptually wrong, because what is embedded in the signature is the Signer's certificate and not only the public key.

@tomascco tomascco self-assigned this Oct 22, 2023
@tomascco tomascco merged commit 3a2fec3 into main Oct 22, 2023
2 checks passed
@tomascco tomascco deleted the rename-signature-param branch October 22, 2023 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant