Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Icon automaticly #14

Open
dragonito opened this issue Mar 9, 2018 · 4 comments
Open

Change Icon automaticly #14

dragonito opened this issue Mar 9, 2018 · 4 comments

Comments

@dragonito
Copy link
Contributor

Change Icon (-color...) when surfing on a site thats already added

@dragonito
Copy link
Contributor Author

Perhaps with 3 states

  • not added
  • already added unread
  • archived

@tolry
Copy link
Owner

tolry commented Mar 9, 2018

Nice idea, but might be a bit intrusive for some people?

Other concern: this might create a lot of traffic (for client + server), since every URL change on any tab will trigger a request.

Have to think about this 😄

@dragonito
Copy link
Contributor Author

Traffic could be a problem. Perhaps its possible to cache it client side.

Colors would be lesser intrusive as changing icons design.

@tolry
Copy link
Owner

tolry commented Oct 26, 2018

quick opinion

  • colors are not self explanatory at all, would need tooltip or equivalent, not a big fan
  • composite icons would be more obvious
    • + for new
    • :pen: for edit
    • ... archive icon
  • about caching: please consider how many different URLs you are opening each and every day? To draw from my own experience: hundreds at least. And that would be really hard to cache except if you would store all URLs from MentalNote in the extension's local storage, which has to major problems
    • this might be really big an browser limitations for this kind of local storage is pretty limited iirc
    • 'cache invalidation'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants