Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AIX use force poll poll Selector by default #1833

Merged
merged 3 commits into from
Oct 3, 2024

Conversation

mustartt
Copy link
Contributor

@mustartt mustartt commented Oct 2, 2024

On AIX, we are having trouble implementing pollset for Selector. We would like to opt-in to the mio_unsupported_force_poll_poll.

@Thomasdezeeuw
Copy link
Collaborator

Can you add CI support for this? See

CheckTargets:
runs-on: ubuntu-latest
timeout-minutes: 10
strategy:
fail-fast: false
matrix:
target:
- aarch64-apple-darwin

@Thomasdezeeuw
Copy link
Collaborator

Seems like the random crate doesn't compile?

  error[E0425]: cannot find function `fill_bytes` in module `sys`
    --> /home/runner/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/std/src/random.rs:66:14
     |
  66 |         sys::fill_bytes(bytes)
     |              ^^^^^^^^^^ not found in `sys`
  
  error[E0425]: cannot find function `fill_bytes` in this scope
    --> /home/runner/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/std/src/sys/random/mod.rs:92:5
     |
  92 |     fill_bytes(&mut buf);
     |     ^^^^^^^^^^ not found in this scope
  

@mustartt
Copy link
Contributor Author

mustartt commented Oct 2, 2024

It seems like we don't have the full stdlib support yet in upstream Rust. It compiles and tests fine downstream.

Would it be okay to leave aix out of the CI for now?

Also, I'm seeing a CI / Sanitizer (leak) in the checks.

@Thomasdezeeuw
Copy link
Collaborator

It seems like we don't have the full stdlib support yet in upstream Rust. It compiles and tests fine downstream.

Would it be okay to leave aix out of the CI for now?

Ok, but let's open an issue for it so we can add it at some point.

Also, I'm seeing a CI / Sanitizer (leak) in the checks.

That's an Rust issue, you can ignore it.

@mustartt
Copy link
Contributor Author

mustartt commented Oct 3, 2024

Thanks for the info. I removed it from CI and created a new issue mentioning it #1834.

@Thomasdezeeuw Thomasdezeeuw merged commit cbb53c7 into tokio-rs:master Oct 3, 2024
59 of 60 checks passed
@Thomasdezeeuw
Copy link
Collaborator

Thanks @mustartt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants