Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't request server time separately for every request #4

Open
rwestlund opened this issue May 26, 2021 · 0 comments
Open

Don't request server time separately for every request #4

rwestlund opened this issue May 26, 2021 · 0 comments

Comments

@rwestlund
Copy link
Contributor

Currently, the SDK makes a first request for the server's time, then puts it inside the envelope that gets hashed and signed. This means there are two round trips for ever request.

This could be improved by getting UNIX time locally, eliminating a whole round trip. The tradeoff is that the SDK would no longer work on machines that have their clocks set incorrectly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant