Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

npm published package 0.4.0 doesn't include the fix in #292 #305

Open
tariknz opened this issue Mar 12, 2021 · 1 comment
Open

npm published package 0.4.0 doesn't include the fix in #292 #305

tariknz opened this issue Mar 12, 2021 · 1 comment

Comments

@tariknz
Copy link

tariknz commented Mar 12, 2021

You can see here https://registry.npmjs.org/printer/-/printer-0.4.0.tgz

macros.hh still has the line:
#if NODE_VERSION_AT_LEAST(13 0, 0) instead of 12, 0, 0 which was merged in #292

Installing from source fixes it.
@si458
Copy link

si458 commented Aug 9, 2021

@tariknz install directly from github seems to fix this issue - npm install tojocky/node-printer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@si458 @tariknz