Extensible commands and abstraction of utility functions #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Abstracted commands outside of the Searcharr class and implemented dynamic loading and registration of command modules to allow for future extensibility.
Moved _load_language, _xlate, and _strip_entities functions to a utility module. Language is loaded into the utility module to curb dependency on the Searcharr class for translation function in commands or other modules. The KeyboardInlineButton definitions were moved to a new buttons module to make the _prepare_reponse and _prepare_user_response functions more readable. Revised the calculations for _prepare_response_users pagination to eliminate offset and num so that it can use the same navigation button code as _prepare_response.
Cleaned up any left over or missing arguments from the button migration. Modified references to series_commands, movie_commands, and book_commands to be consistent with all the other command alias functions so that it would work with a unified method to reduce code reuse.
No new line at end of file, order of imports, and various whitespace concerns.
|
This is awesome and opens a lot of doors for easier expansion in the future. Great stuff. |
|
@jordanella is this all still valid? I remember you mentioned you were working on some additional changes, so I was holding off merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstracted commands outside of the Searcharr class into their own unique modules and implemented dynamic loading and registration of command modules through a command class to allow for easier future extensibility. The validation of authentication and enabled settings at the beginning of respective action requests has been made into a list for each module.
Moved _load_language, _xlate, and _strip_entities functions to a util module. The logger was also moved to util. Translation and logging functions were relocated to eliminate any requirement of dependency injection of the Searcharr class for their use in commands or other modules. The xlate_aliases function was created to minimize code reuse of command populated messages.
The KeyboardInlineButton definitions were moved to a new buttons module to improve readability of _prepare_reponse and _prepare_user_response functions.