Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: Virtual scrolling #68

Open
mesqueeb opened this issue Jul 17, 2021 · 2 comments
Open

FR: Virtual scrolling #68

mesqueeb opened this issue Jul 17, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@mesqueeb
Copy link

I just wanna say I really love this library. I've looked at about 20+ table libraries for Vue, but this is the only library that "gets" it. It doesn't try to force a UI onto the dev, it just provides the logic for the tricky parts. ❤

I have many ideas for improvements, like implementing virtual scrolling and even virtual scrolling combined with dynamic loading of new rows on scroll.

This allows us to render a table of eg. 1 million rows in under 300ms. Otherwise, if you render all those Dom nodes from the start your site or app pretty much becomes unusable performance wise.

My open questions:

  • Are you open for PRs like these?
  • Do they fit in your philosophy of division between the value this library brings VS what we expect devs to implement
  • Are you thinking about some kind of plugin system or tree shaking system where a feature like virtual scrolling is only included when imported?
  • Are you available for further discussion on discord?
@mesqueeb
Copy link
Author

ps my discord is Luca Ban [Mesqueeb]#4774

@tochoromero
Copy link
Owner

Hello @mesqueeb I really appreciate the feedback.

Here are my thought. I really like how focused the plugin is, it doesn't try to do everything but rather do the basic very well.
Instead of adding virtual scrolling to the plugin itself I would be more interested on having documentation on how to incorporate something like https://github.com/Akryum/vue-virtual-scroller.

Virtual scrolling is quite complex and I would much rather have people use specialized libraries for it than trying to get it right on our own.

So if you are interested on putting together a tutorial on how to use Vue virtual scroller alongside Smart Table I would be thrilled to include it in the documentation.

Also, please be aware the next version of the plugin is already in beta, you may want to take a look at it https://vue-smart-table.netlify.app/

Again, I appreciate the feedback and it is always good to hear people find my plugin useful.

@tochoromero tochoromero added the enhancement New feature or request label Jul 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants