-
-
Notifications
You must be signed in to change notification settings - Fork 78
Document::setData() should be nullable #130
Comments
This will require to change signature to |
What about |
By this way you will only be able to do |
I agree that PHP7.1 nullable argument are by far the best way to do it, but I'm ok with the PHP7.0 compatibility. Maybe just keep in mind this thing for a future PHP7.1 support? |
For PHP 7.0 compatibility, we would probably need a |
What about creating a special case: |
Before implement any of proposed ways we need to define concrete use case for it. |
I think that the method Document::setData($element) should accept a nullable value as the constructor does.
The text was updated successfully, but these errors were encountered: