Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid using lodash package #237

Open
svidhani opened this issue Apr 30, 2018 · 0 comments
Open

Avoid using lodash package #237

svidhani opened this issue Apr 30, 2018 · 0 comments

Comments

@svidhani
Copy link
Contributor

svidhani commented Apr 30, 2018

Description

I see lodash has been used a lot where it can be avoided and JS native functions can used instead. Example would be _filter and _includes.

This is also being added to templates which should be discouraged

Additional Information

Using third party libraries can have their own problems

  1. Maintenance headache - there is a cost to upgrade (backward compatibility issues) and cost not to upgrade (deprecation and other dependencies that will require upgrade).
  2. These are not treated as first class citizens and can have performance issues

We should avoid them unless absolutely necessary.

So for filter and includes they are already available on lists/arrays and we should use them.

Aha! Link: https://t-mobile1t-mobile.aha.io/features/JZ-27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant