-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ActiveSupport >=5.1 Support #48
base: master
Are you sure you want to change the base?
Conversation
Did you see the #45? |
Yes I did, the end result of this PR is the same (allow this Gem to be used in Rails 6 projects) however it maintains support with older rails / rubies which seem to be the main objections to merging the referenced PR |
@tmlee This project still maintained? |
You can switch to the |
Yes i will update this gem soon to support newer version of Rails |
@tmlee Please, that would be great! |
I've chosen this version of code to be used. |
Thank you for let us knowing! |
To make it easier for those wishing to use @jmortlock's fork that adds Rails 6 support, you can use this in your gem "time_difference", # Simple TimeDifference operations. NOTE: We use this fork to support Rails 6: https://github.com/tmlee/time_difference/pull/48
github: "jmortlock/time_difference",
ref: "74cfe3fdbf2a50dd80d7c0fdf457bf2b9384edd6" This locks it to that specific git commit as well to avoid any surprises with |
Adds support for active support 6, whilst maintaining compatibility with active support 5 and older ruby versions.