Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ActiveSupport >=5.1 Support #48

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

jmortlock
Copy link

Adds support for active support 6, whilst maintaining compatibility with active support 5 and older ruby versions.

@AlexWayfer
Copy link

Did you see the #45?

@jmortlock
Copy link
Author

Did you see the #45?

Yes I did, the end result of this PR is the same (allow this Gem to be used in Rails 6 projects) however it maintains support with older rails / rubies which seem to be the main objections to merging the referenced PR

@jmortlock
Copy link
Author

@tmlee This project still maintained?

@AlexWayfer
Copy link

@tmlee This project still maintained?

You can switch to the replace_activesupport_with_tardis_and_dry branch of my fork, if you wish.

@tmlee
Copy link
Owner

tmlee commented Feb 3, 2020

@tmlee This project still maintained?

Yes i will update this gem soon to support newer version of Rails

@c2ofh
Copy link

c2ofh commented Feb 6, 2020

@tmlee Please, that would be great!

@kalashnikovisme
Copy link

I've chosen this version of code to be used.

@AlexWayfer
Copy link

I've chosen this version of code to be used.

Thank you for let us knowing!

@joshuapinter
Copy link
Contributor

To make it easier for those wishing to use @jmortlock's fork that adds Rails 6 support, you can use this in your Gemfile:

gem "time_difference",                          # Simple TimeDifference operations. NOTE: We use this fork to support Rails 6: https://github.com/tmlee/time_difference/pull/48
    github: "jmortlock/time_difference",
    ref:    "74cfe3fdbf2a50dd80d7c0fdf457bf2b9384edd6"

This locks it to that specific git commit as well to avoid any surprises with bundle update, should the master branch see any further commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants