Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/llm multi prompt #1070

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

jubeless
Copy link

@jubeless jubeless commented Nov 21, 2024

This PR introduces support for multi-prompt calls in llms, while maintaining backward compatibility with the LLMChain implementation for the call function. That said we believe the default of LLMChain.Call behaviour should not flatten prompts into a single message.

Key Features

  • Add GenerateFromMultiPrompt support in llms.
  • Ensure backward compatibility for chains.Calls when using GenerateFromMultiPrompt.

Backward Compatibility

No breaking changes have been introduced. Tracing is optional and does not affect existing functionality when disabled.

PR Checklist

  • Read the Contributing documentation.
  • Read the Code of conduct documentation.
  • Name your Pull Request title clearly, concisely, and prefixed with the name of the primarily affected package you changed according to Good commit messages (such as memory: add interfaces for X, Y or util: add whizzbang helpers).
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. Fixes #123).
  • Describes the source of new concepts.
  • References existing implementations as appropriate.
  • Contains test coverage for new functions.
  • Passes all golangci-lint checks.

Fix linter errors

FIx linter comment

Added backwards compatibility
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant