Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracing: Added Langsmith Support #1069

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

jubeless
Copy link

@jubeless jubeless commented Nov 21, 2024

This PR introduces LangSmith tracing to the langchaingo library, enhancing debugging and monitoring capabilities for applications leveraging large language models (LLMs). These changes align with our observability needs and have been successfully running in production for several months.

We have subsequent PR ready to improve Inputs and Outputs capturing streamingfast#4

Key Features

LangSmith Tracing Integration:

  • Utilizes the callbacks.Handler to enable tracing capabilities.
  • Tracing is configurable via environment variables or options in the constructor.

Refactor and Enhancements:

  • Ensures complete tracing of function calls to chains.Call.
  • Addresses an issue where callbackHandler set when calling chain.Call was not passed to the llm.Model instance.
  • Introduces a solution to inject callbackHandler into the context and retrieve it within the llm.Model.
  • Demonstrates this implementation using the OpenAI llm.Model.

Backward Compatibility

No breaking changes have been introduced. Tracing is optional and does not affect existing functionality when disabled.

Future Improvements

Refactor HandleLLMGenerateContentStart and HandleLLMGenerateContentEnd into a centralized GenerateContent function in the llms package to reduce code duplication across llms models.

image

PR Checklist

  • Read the Contributing documentation.
  • Read the Code of conduct documentation.
  • Name your Pull Request title clearly, concisely, and prefixed with the name of the primarily affected package you changed according to Good commit messages (such as memory: add interfaces for X, Y or util: add whizzbang helpers).
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. Fixes #123).
  • Describes the source of new concepts.
  • References existing implementations as appropriate.
  • Contains test coverage for new functions.
  • Passes all golangci-lint checks.

@@ -13,7 +13,6 @@ import (
//nolint:all
type Handler interface {
HandleText(ctx context.Context, text string)
HandleLLMStart(ctx context.Context, prompts []string)
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This call was dead code, it was not called anywhere

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant