Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update: parser deprecations #15

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

update: parser deprecations #15

wants to merge 2 commits into from

Conversation

dflynn15
Copy link

@dflynn15 dflynn15 commented Sep 24, 2019 •
edited
Loading

Update the source because Parser::Source::Rewriter was deprecated. Instead we need to use Parser::Source::TreeRewriter to maintain feature parody.

@tjgrathwell at-ing because I can't assign, sorry! 🤷‍♂️

dflynn15 and others added 2 commits September 24, 2019 11:32
@dflynn15
update: parser deprecations
1ce4f03 
- Parser::Source::Rewriter was deprecated and instead we use Parser::Source::TreeRewriter
@dflynn15
patch: add fixes for :header and incorrect comma use
aa7e330
joel added a commit to joel/rails5-spec-converter that referenced this pull request Sep 30, 2021
@joel
update: parser deprecations
1941f9b 
tjgrathwell#15
https://github.com/dflynn15
@dflynn15
@testdouble
@joel joel mentioned this pull request Sep 30, 2021
Merged
joel added a commit to joel/rails5-spec-converter that referenced this pull request Sep 30, 2021
@joel
update: parser deprecations (#7)
8eaf18f 
tjgrathwell#15
https://github.com/dflynn15
@dflynn15
@testdouble
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dflynn15