Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TxnGroup.submit should raise an error if any of the signed_transactions is None #44

Open
fergalwalsh opened this issue Oct 19, 2022 · 0 comments
Open

TxnGroup.submit should raise an error if any of the signed_transactions is None #44

fergalwalsh opened this issue Oct 19, 2022 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@fergalwalsh
Copy link
Contributor

fergalwalsh commented Oct 19, 2022 •
edited
Loading

tinyman-py-sdk/tinyman/utils.py

Line 108 in 40ca553

def submit(self, algod, wait=False):

If any of the elements of signed_transactions is None we should raise an error to inform the user that not all transactions have been signed.

The same applies to client.submit:

tinyman-py-sdk/tinyman/v1/client.py

Line 30 in 40ca553

def submit(self, transaction_group, wait=False):

@fergalwalsh fergalwalsh added enhancement New feature or request good first issue Good for newcomers labels Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fergalwalsh