Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Job's don't transition the JobRunning condition to false once complete #45

Open
chrisdoherty4 opened this issue Jul 7, 2022 · 1 comment
Labels
kind/feature New feature or request triage/discuss Extra discussion needed

Comments

@chrisdoherty4
Copy link
Member

Given jobs can lay in the system for a while the conditions on the job should reflect its current state. Currently, we have JobRunning and JobComplete where 'Complete' represents success. However, we don't transition JobRunning to 'False' once its finished which creates for a confusing API.

It would be useful to reflect the state of the job more accurately and be consistent with other fields on jobs that indicate the job has finished.

@chrisdoherty4 chrisdoherty4 added the kind/feature New feature or request label Jul 7, 2022
@chrisdoherty4 chrisdoherty4 added this to the 0.2 milestone Jul 7, 2022
@chrisdoherty4
Copy link
Member Author

I got to thinking. Perhaps JobRunning isn't right. Perhaps JobStarted is what we need because then it doesn't need updating. This is more how conditions are meant to be used unlike the current configuration that implies a state machine (not what conditions are for).

@chrisdoherty4 chrisdoherty4 added the triage/discuss Extra discussion needed label Sep 8, 2022
@chrisdoherty4 chrisdoherty4 modified the milestones: v0.2, v0.3 Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request triage/discuss Extra discussion needed
Projects
None yet
Development

No branches or pull requests

1 participant