Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task connection authSecretRef namespace does not fallback to the namespace the task is in #187

Open
peterwillis opened this issue Jan 26, 2024 · 1 comment

Comments

@peterwillis
Copy link

I noticed that the namespace field on the authSecretRef is required, and if not set falls back to the default namespace. With a small amount of guidance I am happy to submit a PR that makes it fall back to using the namespace the task is in.

key := types.NamespacedName{Namespace: secretRef.Namespace, Name: secretRef.Name}

@chrisdoherty4
Copy link
Member

@peterwillis Thanks. Tweaking this would require populating the namespace before submitting to the resolveAuthSecretRef() func at both https://github.com/tinkerbell/rufio/blob/main/controller/machine.go#L112 and https://github.com/tinkerbell/rufio/blob/main/controller/task.go#L107.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants