-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tinkerbell/charts: introduce showcase
chart
#89
Open
rpardini
wants to merge
60
commits into
tinkerbell:main
Choose a base branch
from
rpardini:introduce-showcase
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobweinstock
force-pushed
the
introduce-showcase
branch
from
April 2, 2024 15:39
c0505b3
to
30109e3
Compare
rpardini
force-pushed
the
introduce-showcase
branch
from
May 23, 2024 00:01
30109e3
to
d9f5598
Compare
rpardini
force-pushed
the
introduce-showcase
branch
2 times, most recently
from
June 3, 2024 10:45
eb5c9ed
to
15de306
Compare
… download job - sometimes we don't want to download the default hook binaries - this is separate from stack.hook.enabled, which controls the hostPath etc Signed-off-by: Ricardo Pardini <[email protected]>
- `showcase` is a chart that, based on values.yaml dictionaries: - generates Tinkerbell CRs (Hardware/Template/Workflow) for both standard (UEFI) & exotic (supported by Armbian) devices - generates download/process jobs for multiple Hook flavors (see tinkerbell/hook#205) - generates download/process jobs for a few OS images (Ubuntu Cloud Images, Armbian, etc) - should be independent of how one deployed Tinkerbell itself (stack chart, individual components, etc) - A few features: - validates values.yaml for common mistakes; arch must match, etc. - validates & handles rootDisk differences (re-invents "formatPartition()" a bit) - avoids re-downloading Hooks and Images that are already on disk, even if Job re-runs - allows easy way to use - custom Hooks - custom Kernel cmdline parameters at both the Hook & device level - for example `acpi=off` at Hook level and `console=ttyS0` at board level - custom OS images for deployment - reboot or kexec to finish deployment - different partition numbers for OS image's rootfs (some images have ESP, some have a separate `/boot`, etc) - control if growpart and/or ssh/user setup is done during provisioning or not - conversion of OS images (`qemu-to-raw-gzip` and `xz-to-gz`) - has a "merge" mechanism with a common way to set parameters like net gateway, UEFI, etc (also easy to override per-device) - default values have everything `enabled: false` thus showcase should produce nothing by default. - Hooks & Images can be forced `enabled: true` in values.yaml, or - `enabled: true` Devices automatically enable their Hook & Image - Probably missing: - More validations - Currently pointing to my Tinkerbell Actions, which I haven't PR'ed yet - How to use: - Clone it, edit the values.yaml to your liking, and deploy. Signed-off-by: Ricardo Pardini <[email protected]>
Signed-off-by: Ricardo Pardini <[email protected]>
Signed-off-by: Ricardo Pardini <[email protected]>
…edge` hook definition (but no board example yet)
…s, no recommends; 180s timeout
…eds override per-device)
…rs-184; add t95z-cloud-edge image; use qcow2-to-img conversion where relevant
… odroidhc4 example
…nd enable it for fatso images
rpardini
force-pushed
the
introduce-showcase
branch
from
June 9, 2024 17:43
cfc28eb
to
13995ad
Compare
…ggling and enable it for fatso images
…devices by default
…its previous self when redeploying
… more DTs and rebased
rpardini
force-pushed
the
introduce-showcase
branch
from
June 9, 2024 19:00
13995ad
to
b7d362c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tinkerbell/charts: introduce
showcase
chartshowcase
is a chart that, based on values.yaml dictionaries:acpi=off
at Hook level andconsole=ttyS0
at board level/boot
, etc)qemu-to-raw-gzip
andxz-to-gz
)enabled: false
thus showcase should produce nothing by default.enabled: true
in values.yaml, orenabled: true
Devices automatically enable their Hook & ImageSigned-off-by: Ricardo Pardini [email protected]