-
-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] optimise doc #145
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe
If you initialise the
NgcCookieConsentService
in theAppComponent
, then you subscribe to it there, you will never get angOnDestroy()
therefore, it will kind of create this memory leak that the doc talk aboutDescribe the idea you'd like
As the cookie banner could be answered only once, we could user
pipe(take(1))
instead.Describe alternatives you've considered
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: