-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NumPy 2.0 release #111
Comments
If you are installing with But yes if you clone the repo and then set up an environment with the requirements.txt, you could change it to upper bound numpy librosa will release a new version once python-soxr makes a new release that supports Numpy 2.0. There is a beta version of python-soxr 0.4.0 that supports numpy 2.0, as stated in the linked comment, but I think librosa might still break on import with numpy >=2.0. In case it helps, tracking issue for librosa supporting numpy 2.0 is here: librosa/librosa#1831 |
Hey, Thanks for pointing that out. Librosa isn't really necessary and it was causing issues with llvmlite. I've already created a branch without Librosa. We should think about merging this into the master branch, @timsainb. |
Hi @nuniz @timsainb two things:
see e.g. https://dsp.stackexchange.com/questions/71410/difference-between-librosa-stft-and-scipy-signal-stft and also this 2018 post from the lead Librosa maintainer https://groups.google.com/g/librosa/c/Lbh_NT0n7Bo/m/hN045mbeCAAJ If it's just some numerical error at the fifth decimal place then probably most people won't care of course, but I get nervous about that when I want results that rely on some pre-processing to be replicable Also not sure if the change to |
Hi @NickleDave
Maximum value: 0.030 |
Excellent, sounds close enough to me 🚀 |
Since numpy 2.0.0 release, I got this error when importing the module:
I think an easy fix should be to specify a numpy version in the
requirements.txt
, waiting the update of soxr. (dofuuz/python-soxr#28 (comment))The text was updated successfully, but these errors were encountered: