From f2a1ee957badb1a65609e725aaef18739ff2ed40 Mon Sep 17 00:00:00 2001 From: tim_curchod Date: Wed, 15 Sep 2021 07:04:13 +1000 Subject: [PATCH] #9 fixed the titles for the kylie example --- docs/trendy-ssr.md | 14 ++++++++++++++ .../picture-cards/picture-cards.component.ts | 18 +++++++++--------- 2 files changed, 23 insertions(+), 9 deletions(-) diff --git a/docs/trendy-ssr.md b/docs/trendy-ssr.md index c9a048a..70b8b3a 100644 --- a/docs/trendy-ssr.md +++ b/docs/trendy-ssr.md @@ -920,3 +920,17 @@ And how did the functions directory get there in the first place? What was the Undo that change and move up to the main branch. I'm happy to say, that then the deployments to firebase have working links. I'm sorry to say that there is only one link now. The other two links are tied up with the ssr/functions branches. Repair? Why not. On a separate branch. Since that was all failing, and we were about to start over with the angularfire package, couldn't hurt. + +Now, we have a branch named master-repaired. Do we merge that with master? That would cause conflicts if we then want to merge any of the previous (failed) ssr and functions work. I'm worried about my lack of attention to detail, in that I must have missed the links having the doubled-up space character %2520 in the url. How did I not try the direct link with a regular space? + +But that's water under the bridge now. We have a not so useful demo that can be deployed. It's still regular Angular. We have a lot of trial and error learning about the ssr world, and how the choice of Nx and an agnostic workspace.json instead of an Angular based angular.json monorepo complicates everything. I hope someone creates a React app in this project to make that decision worth-while at some point. I'm going to delay the decision to merge this work into the master branch for now, but I'm guessing, that starting over is not the end of the world. + +Some things that were missing from the README workflow section: + +```txt +nx run trendy:server-ssr +nx run trendy:build:prerender --configuration=production +nx run trendy:server:prerender --configuration=production +nx run trendy:firebase --cmd deploy // deploy to firebase +nx run trendy:firebase --cmd serve // test deployment +``` diff --git a/libs/pictures/src/lib/containers/picture-cards/picture-cards/picture-cards.component.ts b/libs/pictures/src/lib/containers/picture-cards/picture-cards/picture-cards.component.ts index bab755e..9afd77c 100644 --- a/libs/pictures/src/lib/containers/picture-cards/picture-cards/picture-cards.component.ts +++ b/libs/pictures/src/lib/containers/picture-cards/picture-cards/picture-cards.component.ts @@ -14,28 +14,28 @@ export class PictureCardsComponent { trends = { Qivit_Tittysure: { pageTitle: 'Qivit Tittysure', - author: 'Transition Cat, Toonify, Henry Curchod', + author: 'Transition Cat, Toonify', keywords: 'Qivit Tittysure, portrait, artwork', description: 'Qivit Tittysure is the soft, dense, light-brown woolly undercoat of the quoll and a small quantity of left over fluff.', linkUrl: 'https://en.wikipedia.org/wiki/Quoll', linkLabel: 'Wikipedia', one: { - title: 'One title', + title: 'Title One is on the left', altText: 'Same as title', imageSrc: './../assets/pictures/qivit-tittysure/qivit-tittysure-1.PNG', - description: 'This is a description of one', + description: 'This is a description of one.', }, two: { - title: 'Two title', + title: 'Title Two is on the right', altText: 'Same as title', imageSrc: './../assets/pictures/qivit-tittysure/qivit-tittysure-2.PNG', - description: 'This is a description of two', + description: 'This is a description of two.', }, }, Kylie_Jenner: { pageTitle: 'Kylie Jenner', - author: 'Transition Cat, Toonify, Henry Curchod', + author: 'Transition Cat, Toonify', keywords: 'Kylie Jenner, portrait, artwork', description: `In April 2017, Jenner was first seen with Travis Scott at Coachella. On February 1, 2018, Jenner gave birth to their daughter, Stormi Webster. @@ -47,7 +47,7 @@ export class PictureCardsComponent { linkUrl: 'https://en.wikipedia.org/wiki/Kylie_Jenner', linkLabel: 'Wikipedia', one: { - pictureTitle: 'Kylie Jenner by Toonify', + title: 'Kylie Jenner by Toonify', altText: 'Kylie Jenner by Toonify', imageSrc: './../assets/pictures/kylie-jenner/kylie-jenner-by-toonify.jpg', @@ -55,8 +55,8 @@ export class PictureCardsComponent { 'Kylie Jenner is entrenched in the war can earn her crown as the highest rated youngest of the closest.', }, two: { - pictureTitle: 'Kylie Jenner by Toonify', - altText: 'Kylie Jenner by Toonify', + title: 'Kylie Jenner by Transition Cat', + altText: 'Kylie Jenner by Transition Cat', imageSrc: './../assets/pictures/kylie-jenner/kylie-jenner-by-transitioncat.jpg', description: 'Sibling rivalry begins again.',