Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proxy #9

Open
vitaliy-kuzmich opened this issue Oct 31, 2015 · 3 comments
Open

proxy #9

vitaliy-kuzmich opened this issue Oct 31, 2015 · 3 comments

Comments

@vitaliy-kuzmich
Copy link
Contributor

are there any way to set the proxy?

@timboudreau
Copy link
Owner

Not currently, but patches are welcome.

On Saturday, October 31, 2015, vitaliy-kuzmich [email protected]
wrote:

are there any way to set the proxy?


Reply to this email directly or view it on GitHub
#9.

http://timboudreau.com

@totemcaf
Copy link

totemcaf commented Feb 2, 2016

Hi timboudreau,

I can work on a patch to add Proxy support, but that requires to move to Netty 4.1 (it includes HttpProxyHandler).

The problem is that the Netty version is in mastfrog-parent and a change on it can affect other projects.

What do you suggest, just add a version number in the this project for Netty or it is able to modify the Netty version in the parent POM?

@timboudreau
Copy link
Owner

I'd say do the work on a branch and override the property in the pom.xml. I can worry about getting the rest of mastfrog-parent onto Netty 4.1.

Until recently it seemed like Netty 5.0 was going to be the successor to 4.0.x (and be available by now), so there is a netty-5 branch (some of the changes may be useful for migrating to 4.1). 4.1 is the next logical target. I haven't looked at what incompatible changes there are there yet, but presumably it's not as extensive as the changes that were needed for 5.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants