Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define dark variables for dark mode #73

Closed
yiendos opened this issue Jul 7, 2020 · 3 comments · Fixed by #74
Closed

Define dark variables for dark mode #73

yiendos opened this issue Jul 7, 2020 · 3 comments · Fixed by #74
Assignees
Labels
Milestone

Comments

@yiendos
Copy link
Contributor

yiendos commented Jul 7, 2020

We need a central store of our dark variables, that enable our dark mode to operate. As a proof of concept for DOCman for WordPress these variables are defined here:
https://github.com/joomlatools/foliokit/blob/master/code/component/base/resources/assets/scss/admin/_dark_variables.scss#L7

This branch will be used in conjunction with:
joomlatools/joomlatools-framework#401

The framework will pull these variables through, and create the admin-dark and light stylesheets. It will also extend the template.helper.ui to ensure that the correct stylesheet is provided to the user's choice.

@yiendos yiendos added the feature label Jul 7, 2020
@yiendos yiendos added this to the Current milestone Jul 7, 2020
@yiendos yiendos self-assigned this Jul 7, 2020
yiendos added a commit that referenced this issue Jul 7, 2020
@yiendos
Copy link
Contributor Author

yiendos commented Oct 20, 2020

@ercanozkaya whoops this really fell down my to do list, going from memory this worked well. This is about moving dark mode changes to the kodekit level so it's available to Joomla and WordPress.

Associated foliokit changes can be found here:
https://github.com/joomlatools/foliokit/issues/89

@yiendos
Copy link
Contributor Author

yiendos commented Oct 29, 2020

@ercanozkaya cool does this mean that future releases of JT products will be dark mode enabled? Which products would start with the new dark/ light mode approach?

@ercanozkaya
Copy link
Contributor

We would have to implement it and test it in JT products. However since there is too much of a user base to anger with dark mode issues (or simply people resisting to change) I wouldn't bother for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants