-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automated README.md generator & individual item files #92
base: main
Are you sure you want to change the base?
Conversation
…iles with the frontmatter for the tools.
…he validation happens so it includes all the relevant items in the README.md when it's generated
Added solid.md to test the github action for auto building README.md
Revert "Added solid.md to test the github action for auto building README.md"
Testing the github action
Revert "Testing the github action"
Added solid.md for final test of the github action
changed again
…y heading anchors
… item to the list
…ed to a new item that is created
Hey @timb-103 , I was hoping you would have had a chance to review this PR. Merging this would allow you to move forward with a more itemised control system & better version control, as each PR would only be touching the file they are adding or updating, not the central I have made sure the upstream commits have been moved into the history of this PR to address any of the merge conflicts that were happening in the README.md, hopefully that helps. I'm happy to assist you and contact each existing PR author individually and get them to push changes to their PR so that it fall inline with the new structure. It's all visible in the Then here is a screenshot of how the updated contribution guidelines look locally & the |
…ensure compatibility when merging.
The branch is now up to date & there is no merge conflicts, I merged the upstream commits & everything is synced. As I had already done the PR a week earlier I have not squashed the commits, suggest that you should handle by doing a squash merge (or rebase merge) of the PR, if you want to bring over the changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@timb-103 -- I went through and added review comments to explain the changes in further details, I hope it helps.
Allows you to automatically build the
README.md
file from files committed, PR's must addname.md
into the respective subfolder ofitems
, then theREADME.md
will be automatically built on merge. There is anexample.md
in items folder, which is referenced in the updated contribution guide.The automated build works using a GitHub Action workflow, to run
npm run build-readme
i added to package.json, which runs a cjs script I wrote to read the items files and build up theREADME.md
. If you prefer not to use an action, you could pull the merged items locally, build theREADME.md
using the command & push the changes. The build script takes into account order property in yaml or defaults to alphabetical listing, make your life easier.The changes to the way the markdown files are as follows:
I have also added additional meta data properties to the yaml of the items, which could be useful for sorting, or additional rendering in the future, to provide more rich content. Mostly are empty properties for now, but could easily be filled as the project grows.
All the meta data for building the
README.md
is all stored in yaml front matter of each item, this means the.md
files for the item could also have a long description or a full page content that could be rendered stored as markdown after the yaml. This could include moving the theinterviews
&guide
markdown content into theiritem
files & adjust where you look for it to render the content , would remove the need for the prefix currently used on the interview files, as the order is stored in the yaml meta data.Let me know what you think, if you want any further details happy to provide it.